![]() ![]() |
|
Browser icons in online list
|
Sep 6 2004, 10:33 PM
Post
#31
|
|
![]() Burn Baby Burn! ![]() ![]() ![]() ![]() Group: Members Posts: 649 Joined: 3-April 04 From: Mexico Member No.: 96,838 IPB Version: Not Applicable |
Thanks for this MOD .. anything that helps to better understand the makeup of your user base is handy indeed. A suggestion:
I used this MOD; but guess that I thought I'd see the browser icons in the "Online Users" list that one see when clicking on "Last Click" ... but I guess this is only for the Board Stats area active user list? Any chacnce that this could be appended to the Last Click Online Users list ... the one where it tells you where a user is on the Site? I have the Board Stats turned off for privacy reasons ... and only use Last Click for myself. In the ACP the area for this MOD is called "Active User List" as opposed to "Online User List" which is the LAST CLICK view ... I think that having it in both areas would be better, especially since the Last Click Online User List also gives you a separate detailing of Guests ... so you can see what browsers they are using too ... more meaningful place to put this hack IMHO ... any chance to update it for this helpful enhancement? I'm guessing that the following files would need modification: Skin/n/skin_online.php sources/Online.php Here is a PS mockup: ![]() Would be SUPER fantastic to have screen resolution listed also (1024, 800, etc.) anybody? Thanks! This post has been edited by Bad Dobby: Sep 7 2004, 02:09 AM -------------------- |
|
|
|
Sep 7 2004, 03:12 AM
Post
#32
|
|
|
Too Much Free Time ![]() ![]() ![]() ![]() ![]() ![]() Group: Members Posts: 7,038 Joined: 27-April 03 Member No.: 7,194 IPB Version: 1.3.x |
*Adds that to the IPB 2.0 version*
Don't believe you can get screen resolution in PHP, think it maybe Javascript only. -------------------- I do not do create/support/upgrade modifications anymore.
I am not currently giving out permission to upgrade my modifications either. It's amazing how nobody reads signatures, I bet if I said i'd ban everyone who messaged me for support, they'd still message me and then complain when they got banned. |
|
|
|
Sep 7 2004, 10:14 AM
Post
#33
|
|
|
Newbie ![]() Group: Members Posts: 8 Joined: 5-April 04 Member No.: 97,440 IPB Version: Not Applicable |
Open IPB_folder/sources/Boards.php
change: CODE $DB->query("SELECT s.id, s.member_id, s.member_name, s.login_type, g.suffix, g.prefix to: CODE $DB->query("SELECT s.id, s.member_id, s.member_name, s.login_type, g.suffix, g.prefix, browser (around line 155) This fixed the same-browser problem.... atleast for me edit: sorry, didn't specify which file... This post has been edited by hæst: Sep 7 2004, 11:57 AM |
|
|
|
Sep 7 2004, 11:14 AM
Post
#34
|
|
![]() Member ![]() ![]() Group: Members Posts: 241 Joined: 29-June 03 From: Somewhere this side of my PC screen Member No.: 23,374 |
which file is that in?
-------------------- |
|
|
|
Sep 7 2004, 11:38 AM
Post
#35
|
|
|
Invisionized ![]() ![]() ![]() ![]() ![]() Group: Members Posts: 1,325 Joined: 2-May 04 Member No.: 104,790 IPB Version: Not Applicable |
it's in /sources/Boards.php
and it worked for me |
|
|
|
Sep 7 2004, 01:29 PM
Post
#36
|
|
![]() Member ![]() ![]() Group: Members Posts: 123 Joined: 7-September 03 From: Michigan US Member No.: 41,057 |
Thanks hæst.
-------------------- |
|
|
|
Sep 7 2004, 01:37 PM
Post
#37
|
|
![]() Burn Baby Burn! ![]() ![]() ![]() ![]() Group: Members Posts: 649 Joined: 3-April 04 From: Mexico Member No.: 96,838 IPB Version: Not Applicable |
QUOTE(Outlaw @ Sep 7 2004, 04:12 AM) *Adds that to the IPB 2.0 version* Don't believe you can get screen resolution in PHP, think it maybe Javascript only. that's bad to taunt and tease like that here in this lowly 1.3 Mod discussion area .... don't you feel shamed and compelled now to reveal the secrets to allow us underlings to have this feature in 1.3? I'm sure it would be a quick fix to move this capability to the Onlines Users screen too ........ -------------------- |
|
|
|
Sep 7 2004, 01:55 PM
Post
#38
|
|
|
Too Much Free Time ![]() ![]() ![]() ![]() ![]() ![]() Group: Members Posts: 7,038 Joined: 27-April 03 Member No.: 7,194 IPB Version: 1.3.x |
IPB 1.3 version is Cows, he gets to decide to add it to it.
-------------------- I do not do create/support/upgrade modifications anymore.
I am not currently giving out permission to upgrade my modifications either. It's amazing how nobody reads signatures, I bet if I said i'd ban everyone who messaged me for support, they'd still message me and then complain when they got banned. |
|
|
|
Sep 7 2004, 02:32 PM
Post
#39
|
|
![]() Burn Baby Burn! ![]() ![]() ![]() ![]() Group: Members Posts: 649 Joined: 3-April 04 From: Mexico Member No.: 96,838 IPB Version: Not Applicable |
well, I have done all the install instructions, including the optional items ... and even with new sessions, I still get icons only for the browser being used .... if I use Firefox, all the icons are Firefox, if I look with IE, all the icons are IE ... for everyone. So this MOD doesn't seem to work for me .... when I tried haest's hack above ... all the icons changed to netscape, hahaha!
I'll wait for the bugs to be worked out..... thanks! -------------------- |
|
|
|
Sep 7 2004, 02:38 PM
Post
#40
|
|
|
Newbie ![]() Group: Members Posts: 8 Joined: 5-April 04 Member No.: 97,440 IPB Version: Not Applicable |
the credit for this should go to the creater(s) of the script...
This adds the browser icons in the Online Users List I think this is what Bad Dobby wanted (without the resolution, think java is the only solution to that) ![]() Added the Guest part.... I made a part in the code bold, this is a part I have added later... Hope this helps Open IPB_forum/sources/Online.php Find around line 26 CODE $idx = new Online; Add before: CODE require_once ("sources/phpsniff/phpSniff.class.php"); ---- Find around line 244: CODE s.login_type, s.member_group, g.prefix, g.suffix Replace with: CODE s.login_type, s.member_group, g.prefix, g.suffix, browser ---- (If the the guest uses an unknown browser) Find around line 417: CODE if ( ($sess['member_id']) ) Add above: CODE if (!$sess['member_name']) { $sess['member_name'] = $sess['prefix'].$ibforums->lang['guest'].$sess['suffix']." ".$sess['ip_address']; $sess['msg_icon'] = ' '; } ---- Find around line 420: CODE $sess['member_name'] = "<a href='{$this->base_url}showuser={$sess['member_id']}'>{$sess['prefix']}{$sess['member_name']}{$sess['suffix']}</a>$inv {$sess['ip_address']}"; Replace with (Updated this part): CODE $client = new phpSniff($sess['browser']); if ($browser = $client->get_property("browser") AND in_array($browser, array("ns", "ie", "op", "mz", "fx", "sf", "kq"))) { $sess['member_browser'] = '<img src="html/browsers/'.$browser.'.png" alt="" /> '; } else { $sess['member_browser'] = ''; } $sess['member_name'] = ($sess['member_browser'] . "<a href='{$this->base_url}showuser={$sess['member_id']}'>{$sess['prefix']}{$sess['member_name']}{$sess['suffix']}</a>$inv {$sess['ip_address']}"); ---- Find around line 454: CODE $sess['member_name'] = $sess['prefix'].$ibforums->lang['guest'].$sess['suffix']." ".$sess['ip_address']; $sess['msg_icon'] = ' '; Replace with: CODE $client = new phpSniff($sess['browser']);
if ($browser = $client->get_property("browser") AND in_array($browser, array("ns", "ie", "op", "mz", "fx", "sf", "kq"))) { $sess['member_browser'] = '<img src="html/browsers/'.$browser.'.png" alt="" /> '; $sess['member_name'] = $sess['member_browser'].$sess['prefix'].$ibforums->lang['guest'].$sess['suffix']." ".$sess['ip_address']; $sess['msg_icon'] = ' '; } This post has been edited by hæst: Sep 7 2004, 04:29 PM |
|
|
|
Sep 7 2004, 02:41 PM
Post
#41
|
|
|
Newbie ![]() Group: Members Posts: 8 Joined: 5-April 04 Member No.: 97,440 IPB Version: Not Applicable |
QUOTE(Bad Dobby @ Sep 7 2004, 09:32 PM) well, I have done all the install instructions, including the optional items ... and even with new sessions, I still get icons only for the browser being used .... if I use Firefox, all the icons are Firefox, if I look with IE, all the icons are IE ... for everyone. So this MOD doesn't seem to work for me .... when I tried haest's hack above ... all the icons changed to netscape, hahaha! I'll wait for the bugs to be worked out..... thanks! Tried the solution I posted? Solution? My bad, I must be blind or something This post has been edited by hæst: Sep 7 2004, 02:45 PM |
|
|
|
Sep 7 2004, 02:46 PM
Post
#42
|
|
![]() Burn Baby Burn! ![]() ![]() ![]() ![]() Group: Members Posts: 649 Joined: 3-April 04 From: Mexico Member No.: 96,838 IPB Version: Not Applicable |
QUOTE(hæst @ Sep 7 2004, 03:41 PM) yes i did ... all i got after that was netscape icons .. can you be more clear on the post above .... who are you responding to and what does this new code that you posted do? Thanks ... maybe we'll get there after all. EDIT ... can you edit your post to put the code inside of CODE tags? I don't trust the way that it breaks inside of normal post view. Thanks! This post has been edited by Bad Dobby: Sep 7 2004, 02:49 PM -------------------- |
|
|
|
Sep 7 2004, 03:15 PM
Post
#43
|
|
|
Invisionized ![]() ![]() ![]() ![]() ![]() Group: Members Posts: 1,325 Joined: 2-May 04 Member No.: 104,790 IPB Version: Not Applicable |
hæst, your code worked for the online list
|
|
|
|
Sep 7 2004, 03:38 PM
Post
#44
|
|
|
Newbie ![]() Group: Members Posts: 8 Joined: 5-April 04 Member No.: 97,440 IPB Version: Not Applicable |
I updated the post with the guest part...
|
|
|
|
Sep 7 2004, 03:40 PM
Post
#45
|
|
![]() Burn Baby Burn! ![]() ![]() ![]() ![]() Group: Members Posts: 649 Joined: 3-April 04 From: Mexico Member No.: 96,838 IPB Version: Not Applicable |
thanks hæst I'll give it a whirl ... where are you geographically btw?
-------------------- |
|
|
|
![]() ![]() |
|
Lo-Fi Version | Time is now: 17th March 2010 - 11:57 PM |